Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Serializable Accumulator trait #22

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add Serializable Accumulator trait #22

merged 1 commit into from
Jul 9, 2024

Conversation

ameyc
Copy link

@ameyc ameyc commented Jul 8, 2024

This PR:

  1. Adds SerializableAccumulator trait
  2. Implements the trait for min and max accumulator
  3. Adds serializers and deserializers for ScalarValue

@ameyc ameyc requested a review from emgeee July 8, 2024 07:05
@ameyc ameyc merged commit 186f720 into main Jul 9, 2024
35 of 49 checks passed
emgeee pushed a commit that referenced this pull request Aug 1, 2024
@sgrebnov
Improve unparser MySQL compatibility (apache#11589)
65dd364 
* Configurable date field extraction style for unparsing (#21)

* Add support for IntervalStyle::MySQL (#18)

* Support alternate format for Int64 unparsing (SIGNED for MySQL) (#22)

* Alternate format support for Timestamp casting (DATETIME for MySQL) (#23)

* Improve

* Fix clippy and docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgeee emgeee emgeee approved these changes

Assignees
No one assigned
Labels
logical-expr physical-expr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameyc @emgeee